-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: balance query with custom transaction model #59
Conversation
6b4867c
to
b25a53a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a unit test in balance.spec.ts
where we would query a balance of a custom schema.
b25a53a
to
ddb8c4e
Compare
64ab0b4
to
578fa61
Compare
I was on vacation for 3 weeks. I will have a look at it today or tomorrow. |
You want to work on this now? :) |
if you have a better/cleaner approach let me know, I will be glad to help |
9ae0ee0
to
0c44f9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont see any dangerous code.
Btw. When the balance snapshotting was implemented I was not very happy about the fact that i did not quite understood the mechanics completely. So I worked the last months on the mongoose code, to get deeper understanding regarding the mongodb and mongoose. Fun Fact: I am now an official contributor of mongoose - LOL. I will maybe, when I have time inspect the snapshotting of balances further more to ensure we have no race conditions or so. |
Problem
Custom schema attributes are not setup correctly for balance query
Solution
parseFilterQuery
logicmeta
attribute only for snapshot related methodsMaybe not the cleaner solution but doesn't change other collections schema/behavior
Related issue: #58