Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does AddMevBundle need to use global pool mutex ? #7

Open
dmarzzz opened this issue Nov 22, 2022 · 2 comments
Open

Does AddMevBundle need to use global pool mutex ? #7

dmarzzz opened this issue Nov 22, 2022 · 2 comments

Comments

@dmarzzz
Copy link

dmarzzz commented Nov 22, 2022

AddMevBundle surely needs to lock for atomicity of adding to the bundle pool (pool.mevBundles), but as far as I can tell it doesn't interact with the rest of the txpool so should be okay to use something like pool.bundleMu.Lock()? Happy to implement if so 😃
@Ruteri
Copy link
Collaborator

Ruteri commented Nov 22, 2022 •
edited

I think it's a good idea!
Keep in mind pool.bundleFetcher is also accessed, but it can also be covered by the bundles-specific lock.

@dmarzzz
Copy link
Author

dmarzzz commented Nov 26, 2022

awesome ty for heads up! will try and get a PR out this coming week

@Paulius0112 Paulius0112 mentioned this issue Dec 5, 2022
Closed
@dmarzzz dmarzzz mentioned this issue Dec 16, 2022
Closed
1 task
avalonche pushed a commit that referenced this issue Feb 7, 2023
@Ruteri @avalonche
Allow resending of the same validator registration (#7)
7ccfa67
avalonche pushed a commit that referenced this issue Mar 9, 2023
@Ruteri @avalonche
Allow resending of the same validator registration (#7)
9e05d57
avalonche pushed a commit that referenced this issue Mar 15, 2023
@Ruteri @avalonche
Allow resending of the same validator registration (#7)
bcf5a94
avalonche pushed a commit that referenced this issue Mar 17, 2023
@Ruteri @avalonche
Allow resending of the same validator registration (#7)
92ceecc
avalonche pushed a commit that referenced this issue Mar 22, 2023
@Ruteri @avalonche
Allow resending of the same validator registration (#7)
d5c972a
avalonche pushed a commit that referenced this issue Jul 6, 2023
@Ruteri @avalonche
Allow resending of the same validator registration (#7)
40eb563
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ruteri @dmarzzz