Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggleable discard for failed revertible transaction hashes #81

Merged
merged 26 commits into from
Aug 3, 2023
Merged

Toggleable discard for failed revertible transaction hashes #81

merged 26 commits into from
Aug 3, 2023

Commits on Jun 25, 2023

  1. Initial commit for discarding first transaction on revert in bundle

    @Wazzymandias
    Wazzymandias committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    ab3c77a View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2023

  1. Update and simplify logic on reverts

    @Wazzymandias
    Wazzymandias committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    16ce372 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2023

  1. Merge remote-tracking branch 'origin/main' into bundle-tx-discard

    @Wazzymandias
    Wazzymandias committed Jul 1, 2023
    Configuration menu
    Copy the full SHA
    6b6e815 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2023

  1. Add feature flag for toggling discard for reverted transaction hashes… 

    …. Add support for dropping revertible transaction hashes in sbundle. Update logic to prevent naked transactions from being discarded since only bundles and sbundles currently support specifying revertible transaction hashes
    @Wazzymandias
    Wazzymandias committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    4f20bca View commit details
    Browse the repository at this point in the history

  2. Update comment

    @Wazzymandias
    Wazzymandias committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    fc81b92 View commit details
    Browse the repository at this point in the history

  3. Update comment

    @Wazzymandias
    Wazzymandias committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    fa2ff4e View commit details
    Browse the repository at this point in the history

  4. Update CLI flag for builder.discard_reverted_hashes

    @Wazzymandias
    Wazzymandias committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    721603a View commit details
    Browse the repository at this point in the history

  5. Add godoc

    @Wazzymandias
    Wazzymandias committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    cd05406 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2023

  1. Update greedy algorithm to only drop for bundles and sbundles

    @Wazzymandias
    Wazzymandias committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    4af9cb7 View commit details
    Browse the repository at this point in the history

  2. Add canRevert to algoconf to make it clearer when we discard transact… 

    …ions
    @Wazzymandias
    Wazzymandias committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    5fd4ba0 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2023

  1. Update comment

    @Wazzymandias
    Wazzymandias committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    09c0216 View commit details
    Browse the repository at this point in the history

  2. Update Sbundle

    @Wazzymandias
    Wazzymandias committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    95e4c7c View commit details
    Browse the repository at this point in the history

  3. Update sbundle to use canRevert

    @Wazzymandias
    Wazzymandias committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    481b801 View commit details
    Browse the repository at this point in the history

  4. Update logic based on PR feedback - only discard revertible transacti… 

    …ons on error, remove unnecessary from commit tx function, add additional unit test that includes bundle when it contains revertible tx that we wish to discard
    @Wazzymandias
    Wazzymandias committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    dcc7507 View commit details
    Browse the repository at this point in the history

  5. Update parameter names to be clearer when revertible transaction has … 

    …error
    @Wazzymandias
    Wazzymandias committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    3d31190 View commit details
    Browse the repository at this point in the history

  6. Remove unused function

    @Wazzymandias
    Wazzymandias committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    a552260 View commit details
    Browse the repository at this point in the history

  7. Update env var

    @Wazzymandias
    Wazzymandias committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    2e5a5b3 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Address PR feedback

    @Wazzymandias
    Wazzymandias committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    70f4914 View commit details
    Browse the repository at this point in the history

  2. Update to only instantiate isRevertibleTx in conditional paths

    @Wazzymandias
    Wazzymandias committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    81c5a34 View commit details
    Browse the repository at this point in the history

  3. Update README

    @Wazzymandias
    Wazzymandias committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    e823952 View commit details
    Browse the repository at this point in the history

  4. Update profit percent comment

    @Wazzymandias
    Wazzymandias committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    40ec427 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. Merge remote-tracking branch 'origin/main' into bundle-tx-discard

    @Wazzymandias
    Wazzymandias committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    4ca2566 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Merge remote-tracking branch 'origin/main' into bundle-tx-discard

    @Wazzymandias
    Wazzymandias committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    e82869c View commit details
    Browse the repository at this point in the history

  2. Update log to debug, add assertion for nil receipt on commit bundle

    @Wazzymandias
    Wazzymandias committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    a1b5e6a View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Add default value to CLI flag

    @Wazzymandias
    Wazzymandias committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    0c4af47 View commit details
    Browse the repository at this point in the history

  2. Update discard tx log to trace - debug is too noisy and less needed a… 

    …fter testing
    @Wazzymandias
    Wazzymandias committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    9e848ab View commit details
    Browse the repository at this point in the history