Allow SSZ builder submissions (also SSZ+GZIP) #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metachris
force-pushed
the
ssz-builder-submission
branch
2 times, most recently
from
da5dd20
to
35b6f9b
Compare
metachris
force-pushed
the
ssz-builder-submission
branch
from
35b6f9b
to
5ddf6b0
Compare
|
Deployed to Flashbots Goerli and Sepolia relays |
jtraglia
previously approved these changes
May 5, 2023
| @@ -1387,7 +1411,7 @@ func (api *RelayAPI) handleSubmitNewBlock(w http.ResponseWriter, req *http.Reque | |||
| log.Warn("could not find slot duty") | |||
| api.RespondError(w, http.StatusBadRequest, "could not find slot duty") | |||
| return | |||
| } else if slotDuty.Entry.Message.FeeRecipient.String() != payload.ProposerFeeRecipient() { | |||
| } else if !strings.EqualFold(slotDuty.Entry.Message.FeeRecipient.String(), payload.ProposerFeeRecipient()) { | |||
There was a problem hiding this comment.
Now a case-insensitive equality comparison. Makes sense, because the SSZ payload is just bytes 👍
There was a problem hiding this comment.
yeah, was needed to work with both JSON and SSZ :)
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #388 +/- ##
==========================================
+ Coverage 20.35% 22.46% +2.10%
==========================================
Files 21 21
Lines 4082 4104 +22
==========================================
+ Hits 831 922 +91
+ Misses 3149 3055 -94
- Partials 102 127 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
|
metachris
force-pushed
the
ssz-builder-submission
branch
from
7540c2b
to
2d51c47
Compare
michaelneuder
approved these changes
May 8, 2023
This was referenced May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Allows block builder submissions also in SSZ, besides JSON.
Decoding performance
✅ I have run these commands
make lintmake test-racego mod tidyCONTRIBUTING.md