Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple getPayload calls for a delivered payload #400

Merged
merged 2 commits into from May 12, 2023

Conversation

avalonche
Copy link
Collaborator

📝 Summary

Allow multiple get payload calls if the block hashes match for the slot.

⛱ Motivation and Context

Supporting #397 to allow repeated getPayload requests for an already delivered payload. Improves redundancy for get payload requests

📚 References


✅ I have run these commands

  • make lint
  • make test-race
  • go mod tidy
  • I have seen and agree to CONTRIBUTING.md

@codecov-commenter
Copy link

codecov-commenter commented May 11, 2023

Codecov Report

Merging #400 (a4795d0) into main (42dfeca) will increase coverage by 0.14%.
The diff coverage is 53.57%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #400      +/-   ##
==========================================
+ Coverage   22.47%   22.62%   +0.14%     
==========================================
  Files          21       21              
  Lines        4111     4128      +17     
==========================================
+ Hits          924      934      +10     
- Misses       3060     3066       +6     
- Partials      127      128       +1     
Flag Coverage Δ
unittests 22.62% <53.57%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
services/api/service.go 22.55% <0.00%> (-0.07%) ⬇️
datastore/redis.go 66.01% <83.33%> (+0.41%) ⬆️

Copy link
Collaborator

@michaelneuder michaelneuder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! nice fix

@metachris metachris merged commit e6387e5 into main May 12, 2023
2 checks passed
@metachris metachris deleted the allow-multiple-getpayload-calls branch May 12, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants