process cancellable bids below floor correctly #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
4 tasks
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #401 +/- ##
==========================================
+ Coverage 30.53% 30.63% +0.10%
==========================================
Files 24 24
Lines 4601 4661 +60
==========================================
+ Hits 1405 1428 +23
- Misses 3012 3040 +28
- Partials 184 193 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dvush
previously approved these changes
May 11, 2023
metachris
force-pushed
the
bid-floor
branch
4 times, most recently
from
c378055
to
0cc88d5
Compare
avalonche
previously approved these changes
May 25, 2023
|
Deployed to production, after running in testnets for a while |
michaelneuder
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
As suggested by @dvush -- cancellable bids below the floor don't need to be validated, and should just delete any previous bid by this builder.
Skips an additional 100-200 validations per slot:
✅ I have run these commands
make lintmake test-racego mod tidyCONTRIBUTING.md