Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis: save ExecPayload in SSZ format (requires update of both builder-API and proposer-API ⚠️) #448

Merged
merged 1 commit into from Jun 5, 2023

Conversation

metachris
Copy link
Collaborator

@metachris metachris commented Jun 5, 2023

📝 Summary

Saving CapellaExecutionPaylaod SSZ-encoded in Redis should be a small performance improvement.

⚠️ Important: changes need to get rolled out to builder-API and proposer-API simultaneously ⚠️

This PR changes the Redis storage key for execution payloads, where the proposer API looks up the getPayload response

The recommended update sequence is as follows:

  1. disable builder-API ingress
  2. update proposer-API and builder-API
  3. enable builder-API ingress

✅ I have run these commands

  • make lint
  • make test-race
  • go mod tidy
  • I have seen and agree to CONTRIBUTING.md

@codecov-commenter
Copy link

Codecov Report

Merging #448 (a219148) into redis-pipeline-2 (8c8dbeb) will decrease coverage by 0.07%.
The diff coverage is 29.62%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@                 Coverage Diff                  @@
##           redis-pipeline-2     #448      +/-   ##
====================================================
- Coverage             29.74%   29.68%   -0.07%     
====================================================
  Files                    24       24              
  Lines                  4693     4706      +13     
====================================================
+ Hits                   1396     1397       +1     
- Misses                 3108     3119      +11     
- Partials                189      190       +1     
Flag Coverage Δ
unittests 29.68% <29.62%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datastore/datastore.go 0.00% <0.00%> (ø)
datastore/redis.go 58.01% <30.76%> (-1.37%) ⬇️

Base automatically changed from redis-pipeline-2 to main June 5, 2023 10:16
@metachris metachris changed the title Redis: save ExecPayload in SSZ format Redis: save ExecPayload in SSZ format (requires update of both builder-API and proposer-API ⚠️) Jun 5, 2023
@metachris metachris merged commit 0ee8de0 into main Jun 5, 2023
3 checks passed
@metachris metachris deleted the redis-ssz branch June 5, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants