Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verification to prevent GetHeaderV1 method to crash #101

Merged
merged 1 commit into from
Apr 24, 2022
Merged

Add verification to prevent GetHeaderV1 method to crash #101

merged 1 commit into from
Apr 24, 2022

Conversation

0xpanoramix
Copy link
Collaborator

@0xpanoramix 0xpanoramix commented Apr 23, 2022

You can find more information about this PR in #100.

Signed-off-by: Luca Georges Francois <luca.georges-francois@epitech.eu>
@codecov-commenter
Copy link

Codecov Report

Merging #101 (84cc91c) into main (1108378) will increase coverage by 0.23%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   59.45%   59.69%   +0.23%     
==========================================
  Files           7        7              
  Lines         518      521       +3     
==========================================
+ Hits          308      311       +3     
  Misses        157      157              
  Partials       53       53              
Flag Coverage Δ
unittests 59.69% <100.00%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/service.go 65.40% <100.00%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1108378...84cc91c. Read the comment docs.

@metachris
Copy link
Collaborator

Thanks!

@metachris metachris merged commit 63daa51 into flashbots:main Apr 24, 2022
screwyprof pushed a commit to screwyprof/mev-boost that referenced this pull request Feb 3, 2023
Signed-off-by: Luca Georges Francois <luca.georges-francois@epitech.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants