Upgrade go-boost-utils #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avalonche
force-pushed
the
go-boost-utils-upgrade
branch
from
1f189b3
to
72d162e
Compare
Codecov Report
β Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## develop #523 +/- ##
===========================================
+ Coverage 70.24% 70.42% +0.18%
===========================================
Files 6 7 +1
Lines 541 1099 +558
===========================================
+ Hits 380 774 +394
- Misses 132 281 +149
- Partials 29 44 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
avalonche
force-pushed
the
go-boost-utils-upgrade
branch
from
72d162e
to
c00cc3b
Compare
|
We'll remove the bellatrix codepaths first, which will make this update quite a bit simpler. |
avalonche
force-pushed
the
go-boost-utils-upgrade
branch
from
c00cc3b
to
f6290b8
Compare
avalonche
commented
Jun 26, 2023
| @@ -537,199 +539,22 @@ func TestGetHeaderBids(t *testing.T) { | |||
| require.Equal(t, 1, backend.relays[0].GetRequestCount(path)) | |||
|
|
|||
| // Value should be 12345 (min bid is 12345) | |||
| resp := new(types.GetHeaderResponse) | |||
There was a problem hiding this comment.
duplicate code originally used to test capella. Now that bellatrix get header is removed, we can remove these tests
avalonche
force-pushed
the
remove-wrapper-types
branch
from
2720a38
to
73c0a58
Compare
avalonche
force-pushed
the
go-boost-utils-upgrade
branch
2 times, most recently
from
14326b4
to
b8248da
Compare
avalonche
force-pushed
the
go-boost-utils-upgrade
branch
from
b8248da
to
3b882d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Summary
Upgrade all the types to attestant by upgrading go-boost-utils in flashbots/go-boost-utils#76. Tidying up types in the
common/folder will be in a follow up PR.β± Motivation and Context
We want to move away from go-boost-utils types entirely and move all types to attestant. This PR is part of the migration move entirely to attestant, switching the util functions to attestant types.
π References
β I have run these commands
make lintmake test-racego mod tidy