Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove process bellatrix payload #537

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Conversation

avalonche
Copy link
Collaborator

πŸ“ Summary

β›± Motivation and Context

πŸ“š References


βœ… I have run these commands

  • make lint
  • make test-race
  • go mod tidy

@avalonche avalonche force-pushed the remove-process-bellatrix-payload branch from 883d84c to 08846c9 Compare June 23, 2023 12:37
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2023

Codecov Report

Merging #537 (9a16491) into develop (54eeaa2) will increase coverage by 0.87%.
The diff coverage is 67.10%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           develop     #537      +/-   ##
===========================================
+ Coverage    70.24%   71.11%   +0.87%     
===========================================
  Files            6        8       +2     
  Lines          541     1177     +636     
===========================================
+ Hits           380      837     +457     
- Misses         132      305     +173     
- Partials        29       35       +6     
Flag Coverage Ξ”
unittests 71.11% <67.10%> (+0.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
cli/main.go 0.00% <0.00%> (ΓΈ)
cli/types.go 0.00% <0.00%> (ΓΈ)
server/mock_types.go 100.00% <ΓΈ> (ΓΈ)
server/types.go 66.15% <66.15%> (ΓΈ)
server/service.go 82.45% <81.99%> (+10.43%) ⬆️
server/utils.go 82.58% <85.15%> (+15.01%) ⬆️
server/mock_relay.go 90.30% <95.04%> (+7.44%) ⬆️
server/relay_entry.go 90.00% <100.00%> (+8.75%) ⬆️

... and 1 file with indirect coverage changes

server/service.go Outdated Show resolved Hide resolved
@metachris
Copy link
Collaborator

looks great on quick check! but let's keep the relay monitor stuff around for now

@avalonche
Copy link
Collaborator Author

as the relay monitor code is not used, it's failing linting. instead of removing I'll just comment out the relay monitor related code for now.

@metachris metachris merged commit ff8f490 into develop Jun 26, 2023
4 checks passed
@metachris metachris deleted the remove-process-bellatrix-payload branch June 26, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants