Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add holesky network details and flag #585

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Add holesky network details and flag #585

merged 1 commit into from
Nov 14, 2023

Conversation

avalonche
Copy link
Collaborator

📝 Summary

This PR adds support for the holesky testnet as the holesky relay at https://boost-relay-holesky.flashbots.net/ is up now.

⛱ Motivation and Context

This provides native support for validators on holesky to test mev-boost and the relay.

📚 References

See holesky testnet for network details.


✅ I have run these commands

  • make lint
  • make test-race
  • go mod tidy

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2023

Codecov Report

Merging #585 (ca63208) into develop (4748718) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           develop     #585      +/-   ##
===========================================
- Coverage    69.41%   69.39%   -0.03%     
===========================================
  Files            7        7              
  Lines         1102     1111       +9     
===========================================
+ Hits           765      771       +6     
- Misses         289      296       +7     
+ Partials        48       44       -4     
Flag Coverage Δ
unittests 69.39% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cli/main.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Collaborator

@metachris metachris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@metachris metachris merged commit ae6406b into develop Nov 14, 2023
7 checks passed
@metachris metachris deleted the holesky branch November 14, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants