Enable examples on public networks #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can we change |
|
Could we include a |
metachris
reviewed
Jan 16, 2024
| @@ -10,7 +9,8 @@ User transactions are stored in the confidential datastore and only a small hint | |||
| Run `Suave` in development mode: | |||
|
|
|||
| ``` | |||
| $ suave --suave.dev | |||
| $ cd ../.. | |||
| $ docker-compose up | |||
There was a problem hiding this comment.
switch back to docker compose? which directory is ../.. supposed to be?
There was a problem hiding this comment.
Yes, we use docker compose to enable the Suave<>L1 integration. The ../.. directory is supposed to mean the root directory of suapp-examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the framework so that the examples can be run on public networks. The configuration parameters (rpc endpoints, funded private keys) can be set with env variables. By default, if nothing is set, the parameters are hardcoded with values from the local devnet.
The env variables are:
KETTLE_PRIVKEY: Funded private key in the Suave network.KETTLE_RPC: Rpc of the kettle. (i.e.https://rpc.rigil.suave.flashbots.net).L1_PRIVKEY: Funded private key for the suave-enabled node network.L1_RPC: Rpc of the suave-enabled node (i.e.http://goerli.rigil.suave.flashbots.net:8545)RELAYER_URL: Url of the relayer to send bundles. (i.e.https://relay-goerli.flashbots.net). This is only required for theapp-ofa-example.Requires flashbots/suave-geth#159