Suave forge integration without SuaveForge.sol #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new way to integrate with Forge. Before, a separate library (
SuaveForge.sol) was used to interact with the Suave node and perform the precompile requests. However, scripts or tests written with this library could not be deployed since they used forge-specific precompiles (i.e.vm.ffi).In the new approach, we keep the same logic to interact with Suave (through
vm.fficalls) but that logic is deployed directly at the addresses of the precompiles with a forge cheat-code (vm.etch). Thus, we can use the normalSuave.sollibrary and resolve the logic requests as we do withSuaveForge.sol.