Arp #182
Merged
Arp #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UlricQin
reviewed
Sep 17, 2022
inputs/arp_packet/arp_packet.go
Outdated
| var ( | ||
| snapshot_len int32 = 1024 | ||
| promiscuous bool = false | ||
| timeout time.Duration = 30 * time.Second |
There was a problem hiding this comment.
promiscuous、timeout 作为 instance的配置是不是好点
UlricQin
reviewed
Sep 17, 2022
inputs/arp_packet/arp_packet.go
Outdated
| var err error | ||
| ins.EthHandle, err = pcap.OpenLive(ins.Ethdevice, snapshot_len, promiscuous, timeout) | ||
| if err != nil { | ||
| log.Fatal(err) |
There was a problem hiding this comment.
不能用log.Fatal(err)，这个方法内部会直接panic。
UlricQin
reviewed
Sep 17, 2022
inputs/arp_packet/arp_packet.go
Outdated
| return types.ErrInstancesEmpty | ||
| } | ||
| go ins.arpStat() | ||
| fmt.Println("I! start arp stat") |
There was a problem hiding this comment.
不用fmt打日志，用log.Println("I! start arp stat")
下面代码里打印日志的地方也是一样的问题
UlricQin
reviewed
Sep 17, 2022
inputs/arp_packet/arp_packet.go
Outdated
| sourceAddr := sip.String() | ||
| dip = arp.DstProtAddress | ||
| if sourceAddr == ins.LocalIP { | ||
| fmt.Println("send req") |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.