Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix instances with nil client #486

Merged
merged 1 commit into from Apr 27, 2023
Merged

fix instances with nil client #486

merged 1 commit into from Apr 27, 2023

Conversation

kongfei605
Copy link
Collaborator

@kongfei605 kongfei605 commented Apr 26, 2023 •
edited

  1. 标记instance是否初始化成功
  2. gather调用前会判断标记位，没初始化的不调用gather

场景：比如配置只有[[instances]]但是address为空，这样就没办法Init，就不会有一个client，但是gather方法中直接用了client.ping() , 像redis/mysql/oracle 插件。

@kongfei605 kongfei605 mentioned this pull request Apr 27, 2023
Merged
@kongfei605 kongfei605 merged commit 6dab04b into flashcatcloud:main Apr 27, 2023
@kongfei605 kongfei605 deleted the fix_empty_instance branch June 11, 2023 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kongfei605