增加nsq消息队列采集 #537
Merged
增加nsq消息队列采集 #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 12, 2023 18:05
kongfei605
reviewed
Jun 12, 2023
| } | ||
|
|
||
| func (ins *Instance) GetTopicInfo() ([]string, error) { | ||
| client := http.Client{Timeout: 5 * time.Second} |
kongfei605
reviewed
Jun 12, 2023
| if err != nil { | ||
| return nil, err | ||
| } | ||
| //req.SetBasicAuth(username, password) |
There was a problem hiding this comment.
basic auth 和 自定义header也可以放到配置中
kongfei605
reviewed
Jun 12, 2023
| } | ||
|
|
||
| func getQueuesInfo(URL, topicName string) (int, error) { | ||
| client := http.Client{Timeout: 5 * time.Second} |
There was a problem hiding this comment.
5秒这个 放到配置中，Init时添加默认值，这里就可以直接用ins.Timeout 了
|
先merge了，我来改一下 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
目前只增加depth指标，这个最常用，是消息队列的积压指标，指标名称：nsq_channel_depth
