Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokens tab shows incorrect Token graphics for Normal tokens #54

Closed
goldstinger opened this issue Jun 1, 2020 · 0 comments
Closed

Tokens tab shows incorrect Token graphics for Normal tokens #54

goldstinger opened this issue Jun 1, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@goldstinger
Copy link

goldstinger commented Jun 1, 2020

Describe the bug
Navigating to the Normal tokens in the Tokens tab will sometimes show the incorrect graphic out of order for tokens. This issue will persist for the rest of the game session.

Screenshots
Image

Reproduction Steps
Follow these steps to reproduce bug:

  1. Start up FFR R^3 version 1.1.1
  2. Navigate to 'Tokens' at the top of the screen.
  3. Select 'Normal Tokens' on the left side.
  4. See error.

Reproduction Rate
This bug occurs roughly 80% of the time. If it doesn't happen for you, close the game and follow the Reproduction Steps again.

Expected behaviour
Should display the correct token graphics for each token as displayed on profiles on the website.

Desktop (please complete the following information):

  • Platform: Air
  • Version: 1.1.1

Additional context or comments
OS Name Microsoft Windows 7 Home Premium
Version 6.1.7601 Service Pack 1 Build 7601
Other OS Description Not Available
OS Manufacturer Microsoft Corporation
System Name USER-PC
System Manufacturer MSI
System Model MS-7A70
System Type x64-based PC
Processor Intel(R) Core(TM) i7-7700 CPU @ 3.60GHz, 3601 Mhz, 4 Core(s), 8 Logical Processor(s)
BIOS Version/Date American Megatrends Inc. A.10, 05/12/2016
SMBIOS Version 3.0
Windows Directory C:\Windows
System Directory C:\Windows\system32
Boot Device \Device\HarddiskVolume2
Locale Canada
Hardware Abstraction Layer Version = "6.1.7601.24117"
User Name User-PC\User
Time Zone Eastern Daylight Time
Installed Physical Memory (RAM) 16.0 GB
Total Physical Memory 16.0 GB
Available Physical Memory 11.4 GB
Total Virtual Memory 31.9 GB
Available Virtual Memory 26.3 GB
Page File Space 16.0 GB
Page File C:\pagefile.sys

@goldstinger goldstinger added the bug Something isn't working label Jun 1, 2020
Psycast added a commit that referenced this issue Jun 25, 2020
Issue was a race condition while swapping between token types. Switching types would call "downloadTokenImage" which would overwrite the ACTIVE_DOWNLOAD and cause the result the result of a ongoing download to use the wrong token information result.
Zageron pushed a commit that referenced this issue Jun 25, 2020
Issue was a race condition while swapping between token types. Switching types would call "downloadTokenImage" which would overwrite the ACTIVE_DOWNLOAD and cause the result the result of a ongoing download to use the wrong token information result.
@Psycast Psycast closed this as completed Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants