Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

find_package(cereal) fails to find cereal #1086

Closed
yurivict opened this issue Mar 15, 2023 · 2 comments
Closed

find_package(cereal) fails to find cereal #1086

yurivict opened this issue Mar 15, 2023 · 2 comments
Assignees
@jacobkahn
Labels
bug Something isn't working

Comments

@yurivict
Copy link

yurivict commented Mar 15, 2023 •
edited
Loading

Bug Description

When find_package(cereal) is after the line set(CMAKE_MODULE_PATH "${CMAKE_CURRENT_LIST_DIR}/cmake") - it fails to find cereal. It appears that Findcereal.cmake causes this failure. It looks like Findcereal.cmake isn't needed since cereal provides its own cmake scripts.

Reproduction Steps

Regular configure.

Platform and Hardware

FreeBSD 13.1

cereal-1.3.2
@yurivict yurivict added the bug Something isn't working label Mar 15, 2023
@jacobkahn
Copy link
Member

@yurivict — this was here to support legacy configurations, but removing it makes sense now. I'll do so soon.

@jacobkahn jacobkahn self-assigned this Mar 15, 2023
@jacobkahn
Copy link
Member

@yurivict Findcereal.cmake isn't in main — it was removed in #1060 favor of the config-based approach. If you're checked out to an old version, you should use old dependencies as loosely specified by CMake. If not, I'd recommend sticking to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobkahn jacobkahn

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yurivict @jacobkahn