Swap to CMake FetchContent and cleanup modules #1060
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
jacobkahn
force-pushed
the
module_cleanup
branch
from
868173d
to
5b4b937
Compare
|
@jacobkahn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
jacobkahn
added a commit
to jacobkahn/flashlight
that referenced
this pull request
Feb 21, 2023
Summary: See title. CMake `FetchContent` solves a bunch of install-related issues and makes reasoning about configurable downstream dependencies easier. Pull Request resolved: flashlight#1060 Test Plan: CI + local builds without the required dependencies and with `FL_BUILD_STANDALONE` set to `ON` Reviewed By: bwasti Differential Revision: D41795910 Pulled By: jacobkahn fbshipit-source-id: 61d82af79c42cdafb4ea37a78cc07950518a5e8c
jacobkahn
added a commit
to jacobkahn/flashlight
that referenced
this pull request
Feb 21, 2023
Summary: See title. CMake `FetchContent` solves a bunch of install-related issues and makes reasoning about configurable downstream dependencies easier. Pull Request resolved: flashlight#1060 Test Plan: CI + local builds without the required dependencies and with `FL_BUILD_STANDALONE` set to `ON` Reviewed By: bwasti Differential Revision: D41795910 Pulled By: jacobkahn fbshipit-source-id: af7713feb1ff13ce441ceedb9e2e33e5dec948ba
jacobkahn
force-pushed
the
module_cleanup
branch
from
5b4b937
to
1446a9c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41795910 |
jacobkahn
added a commit
to jacobkahn/flashlight
that referenced
this pull request
Feb 21, 2023
Summary: See title. CMake `FetchContent` solves a bunch of install-related issues and makes reasoning about configurable downstream dependencies easier. Pull Request resolved: flashlight#1060 Test Plan: CI + local builds without the required dependencies and with `FL_BUILD_STANDALONE` set to `ON` Reviewed By: bwasti Differential Revision: D41795910 Pulled By: jacobkahn fbshipit-source-id: 89ccf72a7f1d6d7c4f0d9f24e04c5cb8690f6a95
jacobkahn
force-pushed
the
module_cleanup
branch
from
1446a9c
to
bbf4a4b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41795910 |
jacobkahn
added a commit
to jacobkahn/flashlight
that referenced
this pull request
Feb 21, 2023
Summary: See title. CMake `FetchContent` solves a bunch of install-related issues and makes reasoning about configurable downstream dependencies easier. Pull Request resolved: flashlight#1060 Test Plan: CI + local builds without the required dependencies and with `FL_BUILD_STANDALONE` set to `ON` Reviewed By: bwasti Differential Revision: D41795910 Pulled By: jacobkahn fbshipit-source-id: 9f9bfedd2157d1ad8f50ad3ed3e953e6ad20d9c7
jacobkahn
force-pushed
the
module_cleanup
branch
from
bbf4a4b
to
caeeb98
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41795910 |
Summary: See title. CMake `FetchContent` solves a bunch of install-related issues and makes reasoning about configurable downstream dependencies easier. Pull Request resolved: flashlight#1060 Test Plan: CI + local builds without the required dependencies and with `FL_BUILD_STANDALONE` set to `ON` Reviewed By: bwasti Differential Revision: D41795910 Pulled By: jacobkahn fbshipit-source-id: 5ae2f0c037d4a0e3be68d8f1dd103c87652ab0dd
|
This pull request was exported from Phabricator. Differential Revision: D41795910 |
jacobkahn
force-pushed
the
module_cleanup
branch
from
caeeb98
to
bd17e8e
Compare
jacobkahn
added a commit
to jacobkahn/flashlight
that referenced
this pull request
Feb 21, 2023
Summary: See title. CMake `FetchContent` solves a bunch of install-related issues and makes reasoning about configurable downstream dependencies easier. Pull Request resolved: flashlight#1060 Test Plan: CI + local builds without the required dependencies and with `FL_BUILD_STANDALONE` set to `ON` Reviewed By: bwasti Differential Revision: D41795910 Pulled By: jacobkahn fbshipit-source-id: 2921fb10317b5e8d223eac0a7843d65115e612c0
|
@jacobkahn merged this pull request in 80f59a2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title. CMake
FetchContentsolves a bunch of install-related issues and makes reasoning about configurable downstream dependencies easier.Test plan: CI +
local builds without the required dependencies and with
FL_BUILD_STANDALONEset toON