Add Tensor broadcasting for binary ops #775
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D32678121 |
jacobkahn
added a commit
to jacobkahn/flashlight
that referenced
this pull request
Dec 8, 2021
Summary: Pull Request resolved: flashlight#775 Internally use ArrayFire's `af::batchFunc` to add Tensor broadcasting behavior for all binary operations. This doesn't add broadcasting to some operations (e.g. in place ops) or weird indexing assignment ops, but we can add those later after some discussion on behavior — binary op behavior is pretty unambiguous. Differential Revision: D32678121 fbshipit-source-id: fbfc2cbc4954e5d7dd111d847d23a54269ce893b
jacobkahn
force-pushed
the
export-D32678121
branch
from
328a5d8
to
88013f2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D32678121 |
jacobkahn
added a commit
to jacobkahn/flashlight
that referenced
this pull request
Dec 8, 2021
Summary: Pull Request resolved: flashlight#775 Internally use ArrayFire's `af::batchFunc` to add Tensor broadcasting behavior for all binary operations. This doesn't add broadcasting to some operations (e.g. in place ops) or weird indexing assignment ops, but we can add those later after some discussion on behavior — binary op behavior is pretty unambiguous. Differential Revision: D32678121 fbshipit-source-id: 355cedd0e33e22bdad03845836bbad03df40c7a4
jacobkahn
force-pushed
the
export-D32678121
branch
from
88013f2
to
73e66df
Compare
|
This pull request was exported from Phabricator. Differential Revision: D32678121 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D32678121 |
jacobkahn
added a commit
to jacobkahn/flashlight
that referenced
this pull request
Jan 10, 2022
Summary: Pull Request resolved: flashlight#775 Internally use ArrayFire's `af::batchFunc` to add Tensor broadcasting behavior for all binary operations. This doesn't add broadcasting to some operations (e.g. in place ops) or weird indexing assignment ops, but we can add those later after some discussion on behavior — binary op behavior is pretty unambiguous. Differential Revision: D32678121 fbshipit-source-id: e25b1b94da7fedf1f2b1c6db20f9333871afafb0
jacobkahn
force-pushed
the
export-D32678121
branch
from
73e66df
to
9277a0a
Compare
Summary: Pull Request resolved: flashlight#775 Internally use ArrayFire's `af::batchFunc` to add Tensor broadcasting behavior for all binary operations. This doesn't add broadcasting to some operations (e.g. in place ops) or weird indexing assignment ops, but we can add those later after some discussion on behavior — binary op behavior is pretty unambiguous. Differential Revision: D32678121 fbshipit-source-id: da2b5a3746fbca86b4cf0f32dd900ba4f4b5ad18
jacobkahn
force-pushed
the
export-D32678121
branch
from
9277a0a
to
f8a9f03
Compare
|
This pull request was exported from Phabricator. Differential Revision: D32678121 |
jacobkahn
added a commit
to jacobkahn/flashlight
that referenced
this pull request
Jan 11, 2022
Summary: Pull Request resolved: flashlight#775 Internally use ArrayFire's `af::batchFunc` to add Tensor broadcasting behavior for all binary operations. This doesn't add broadcasting to some operations (e.g. in place ops) or weird indexing assignment ops, but we can add those later after some discussion on behavior — binary op behavior is pretty unambiguous. Differential Revision: D32678121 fbshipit-source-id: 209964ae03b6ec4ca8958cfdec99dc0cbabf7122
jacobkahn
added a commit
to jacobkahn/flashlight
that referenced
this pull request
Jan 11, 2022
Summary: Pull Request resolved: flashlight#775 Internally use ArrayFire's `af::batchFunc` to add Tensor broadcasting behavior for all binary operations. This doesn't add broadcasting to some operations (e.g. in place ops) or weird indexing assignment ops, but we can add those later after some discussion on behavior — binary op behavior is pretty unambiguous. Differential Revision: D32678121 fbshipit-source-id: 925a5e975bc57a8a7eb26db50bde54100130b48b
jacobkahn
added a commit
to jacobkahn/flashlight
that referenced
this pull request
Jan 11, 2022
Summary: Pull Request resolved: flashlight#775 Internally use ArrayFire's `af::batchFunc` to add Tensor broadcasting behavior for all binary operations. This doesn't add broadcasting to some operations (e.g. in place ops) or weird indexing assignment ops, but we can add those later after some discussion on behavior — binary op behavior is pretty unambiguous. Differential Revision: D32678121 fbshipit-source-id: f5e1cccffe159147375b1eb5174eaf70ddb035d7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Internally use ArrayFire's
af::batchFuncto add Tensor broadcasting behavior for all binary operations. This doesn't add broadcasting to some operations (e.g. in place ops) or weird indexing assignment ops, but we can add those later after some discussion on behavior — binary op behavior is pretty unambiguous.Differential Revision: D32678121