Clean up Tensor and Shape stringification #808
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D32678121 fbshipit-source-id: f1015b231ade210bb75cba69769f9dfa4850230a
Differential Revision: D32902722 fbshipit-source-id: 31c05c3e610f11053ad05e894a1d412cb0bfd18a
Differential Revision: D32159630 fbshipit-source-id: ed393daf01f81ed109674c89e8f3df555bcb1504
Differential Revision: D33143590 fbshipit-source-id: dc6f3dbf984dec5110ea6b56ed6b7c61310a5597
Differential Revision: D33159882 fbshipit-source-id: ede8e8ee99e6f8e0522644a234e0d74e5c0a0bf6
Summary: See title. Add `Tensor::toString()` and `Shape::toString()` explicitly and use in `operator<<` for `ArrayFireTensor`. Reviewed By: benoitsteiner Differential Revision: D33159894 fbshipit-source-id: 4e9fec4758258382b77538abac8c254a777a7396
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D33159894 |
jacobkahn
added a commit
to jacobkahn/flashlight
that referenced
this pull request
Jan 11, 2022
Summary: Pull Request resolved: flashlight#808 See title. Add `Tensor::toString()` and `Shape::toString()` explicitly and use in `operator<<` for `ArrayFireTensor`. Reviewed By: benoitsteiner Differential Revision: D33159894 fbshipit-source-id: e02d92827572d4eec476ecbee4b123d8abb6692b
jacobkahn
added a commit
to jacobkahn/flashlight
that referenced
this pull request
Jan 11, 2022
Summary: Pull Request resolved: flashlight#808 See title. Add `Tensor::toString()` and `Shape::toString()` explicitly and use in `operator<<` for `ArrayFireTensor`. Reviewed By: benoitsteiner Differential Revision: D33159894 fbshipit-source-id: bc6a32658191933b37662c44ac13561e1bd3e305
jacobkahn
added a commit
to jacobkahn/flashlight
that referenced
this pull request
Jan 11, 2022
Summary: Pull Request resolved: flashlight#808 See title. Add `Tensor::toString()` and `Shape::toString()` explicitly and use in `operator<<` for `ArrayFireTensor`. Reviewed By: benoitsteiner Differential Revision: D33159894 fbshipit-source-id: 99896838837c2607ed1f10f020bd6c7482b9d8d5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: See title. Add
Tensor::toString()andShape::toString()explicitly and use inoperator<<forArrayFireTensor.Reviewed By: benoitsteiner
Differential Revision: D33159894