Add shape indexing protection #810
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D32678121 fbshipit-source-id: fe6f8a25768d8dd4bb139d48095ebdaa7179b6e7
Differential Revision: D32902722 fbshipit-source-id: b2f4fc0e6ff64eec6b947b6b27e8517a835a6730
Differential Revision: D32159630 fbshipit-source-id: 7e693422b8d55878b5f1d8466e70a40c2eec43bb
Summary: See title. We control the overload, so check bounds in `Shape::operator[]`. Ended up revealing several subtle stack overwriting bugs that caused some nondeterministic behavior which are now resolved upstream. Differential Revision: D33143590 fbshipit-source-id: b361787887b31f41477ac19476816c72d24a1e71
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D33143590 |
jacobkahn
added a commit
to jacobkahn/flashlight
that referenced
this pull request
Jan 11, 2022
Summary: Pull Request resolved: flashlight#810 See title. We control the overload, so check bounds in `Shape::operator[]`. Ended up revealing several subtle stack overwriting bugs that caused some nondeterministic behavior which are now resolved upstream. Differential Revision: D33143590 fbshipit-source-id: c2116a7ed4ec21735cbcc26c029652fa4db46fab
jacobkahn
added a commit
to jacobkahn/flashlight
that referenced
this pull request
Jan 11, 2022
Summary: Pull Request resolved: flashlight#810 See title. We control the overload, so check bounds in `Shape::operator[]`. Ended up revealing several subtle stack overwriting bugs that caused some nondeterministic behavior which are now resolved upstream. Differential Revision: D33143590 fbshipit-source-id: afccbdbf97ce4fe1687003c6e612c2a6d89142b1
jacobkahn
added a commit
to jacobkahn/flashlight
that referenced
this pull request
Jan 11, 2022
Summary: Pull Request resolved: flashlight#810 See title. We control the overload, so check bounds in `Shape::operator[]`. Ended up revealing several subtle stack overwriting bugs that caused some nondeterministic behavior which are now resolved upstream. Differential Revision: D33143590 fbshipit-source-id: 471025ac453f7b1e61c63a2576abf43cdcb2f9cf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: See title. We control the overload, so check bounds in
Shape::operator[]. Ended up revealing several subtle stack overwriting bugs that caused some nondeterministic behavior which are now resolved upstream.Differential Revision: D33143590