Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing \r\n after HELO/EHLO #44

Merged
merged 2 commits into from
Jan 19, 2017
Merged

Missing \r\n after HELO/EHLO #44

merged 2 commits into from
Jan 19, 2017

Conversation

phires
Copy link
Collaborator

@phires phires commented Jan 19, 2017

Added missing \r\n after HELO/EHLO response.
Clients would never care for the SIZE response

phires and others added 2 commits January 19, 2017 19:23
@phires
Missing \r\n after HELO/EHLO
b763247 
Added missing \r\n after HELO/EHLO response.
Clients would never care for the SIZE response
@flashmob
Only ehlo should append \r\n
4f4d318 
Helo returns with a single line, ehlo may have additional lines
@flashmob
Copy link
Owner

flashmob commented Jan 19, 2017 •
edited

Thanks!
Looks like the tests were breaking because only EHLO was affected. Made the changes now and looks like good to go.
Thanks again.

@flashmob flashmob merged commit 0a1bf91 into flashmob:master Jan 19, 2017
@flashmob flashmob mentioned this pull request Jan 20, 2017
Closed
@phires phires mentioned this pull request Jan 26, 2017
Merged
flashmob pushed a commit that referenced this pull request Jan 28, 2017
@phires @flashmob
Tests (#62)
0b01b75 
* Additional test for HELO/EHLO, see issue #44.
Also raises code coverage, see issue #45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@phires @flashmob