Programmer dirtyjtag_spi can never be enabled

[davidthings]

In the parade of programmer enablement in the Makefile, CONFIG_DIRTYJTAG_SPI being set should add a define to FEATURE_FLAGS like every other programmer. Sadly it adds it to (creates) FEATURE_CFLAGS - a mistake.

Your DirtyJTAG stanza (approximately line 836) should look like this:

ifeq ($(CONFIG_DIRTYJTAG_SPI), yes)
FEATURE_FLAGS += -D'CONFIG_DIRTYJTAG_SPI=1'
PROGRAMMER_OBJS += dirtyjtag_spi.o
ACTIVE_PROGRAMMERS += dirtyjtag_spi
endif

'make config', 'make clean', 'make' and you're in (dirty) business

$ ./flashrom -L
...
Supported programmers:
dummy, raiden_debug_spi, ft2232_spi, serprog, buspirate_spi, dediprog,
developerbox, rayer_spi, pony_spi, linux_mtd, linux_spi, usbblaster_spi,
pickit2_spi, ch341a_spi, ch347_spi, digilent_spi, stlinkv3_spi, dirtyjtag_spi
...

[github-actions]

Thank you for your contribution. The flashrom project does not handle GitHub issues or pull requests, since this repository on GitHub is just a mirror of our actual repository. Thus, we would like to encourage you to have a look at on our development guidelines and submit your patch to review.coreboot.org. Issues are handled over our ticket system. If you have questions, feel free to reach out to us. There are multiple ways to contact us.