Allow flipping mapbox coordinates to/from db #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current Leaflet implementation expects coordinates in latitude-longitude order but GeoJSON and PostGIS works the other way around with lng first. These changes work around this behavior by passing the data to and from db through PostGIS’s `ST_FlipCoordinates` function if the setting `MAPBOX_FIX_POINT_COORDINATES` is something truthy. This is to not break the current behavior. Right now a warning is emitted when this setting hasn’t been enabled but I would recommend to remove this setting and make its behavior the default in the next major version.
jacobsvante
force-pushed
the
mapbox-flip-coordinates
branch
from
4ebe19f
to
86d2542
Compare
jacobsvante
added a commit
to jacobsvante/flask-admin
that referenced
this pull request
Sep 29, 2016
Mistake on my part. See discussion in pallets-eco#1341.
jacobsvante
added a commit
to jacobsvante/flask-admin
that referenced
this pull request
Sep 29, 2016
Mistake on my part. See discussion in pallets-eco#1341. Fixes pallets-eco#1341
jacobsvante
added a commit
to jacobsvante/flask-admin
that referenced
this pull request
Oct 23, 2016
Mistake on my part. See discussion in pallets-eco#1341.
mrjoes
added a commit
that referenced
this pull request
Oct 24, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Leaflet implementation expects coordinates in latitude-longitude order but
GeoJSONandPostGISworks the other way around with longitude first. These changes work around this behavior by passing the data to and from the db through PostGIS’sST_FlipCoordinatesfunction if the settingMAPBOX_FIX_COORDINATES_ORDERis set to something truthy. It's an opt-in so we don't break the current behavior. A warning is emitted when this setting is not enabled, but I would recommend to remove this setting and make its behavior the default in the next major version.The commit isn't really as big as it seems, my fingers were just itching to make the code a bit more readable. Basically the only change is the new
_flip_coordinatesmethod, which is a no-op without the new setting.