Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add json support to SQLA backend #1245

Merged
merged 2 commits into from
Mar 28, 2016
Merged

Conversation

pawl
Copy link
Member

@pawl pawl commented Mar 27, 2016

This pull request adds the ability to edit JSON columns to the SQLA backend.

It accomplishes this by moving the GeoAlchemy backend's JSONField into flask_admin/form/fields.py to be shared between the two backends. Also, some improvements were made to the JSONField's ability to handle non-ascii characters.

Editing:
screenshot1

List View:
screenshot2

Invalid JSON:
screenshot3

@mrjoes
Copy link
Member

mrjoes commented Mar 27, 2016

Lets use PostgreSQL 9.4. Otherwise - good to go.

@pawl
Copy link
Member Author

pawl commented Mar 27, 2016

Just changed it to use 9.4 here: 711b33e

@mrjoes mrjoes merged commit 3c45e75 into flask-admin:master Mar 28, 2016
@pawl
Copy link
Member Author

pawl commented Mar 28, 2016

@mrjoes I just updated translations. Think we're ready for a release that includes this?

@mrjoes
Copy link
Member

mrjoes commented Mar 28, 2016

I think so. Do we have anything else pending?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants