Improved isNewestVersion function

flask-dashboard · Sep 7, 2020 · d417693 · d417693
1 parent 0afd189
commit d417693
Show file tree

Hide file tree

Showing 4 changed files with 84 additions and 13,737 deletions.
diff --git a/flask_monitoringdashboard/frontend/js/controllers/OverviewController.js b/flask_monitoringdashboard/frontend/js/controllers/OverviewController.js
@@ -70,8 +70,10 @@ function isNewestVersion(pypi_version, dashboard_version) {
     let dashboard_version_array = dashboard_version.split('.');
     for (let i = 0; i < 3; i++) {
         if (pypi_version_array[i] > dashboard_version_array[i]) {
-            return false;
+            return false;  // using an older version.
+        } else if (pypi_version_array[i] < dashboard_version_array[i]){
+            return true;  // using a newer version.
         }
     }
-    return true;
+    return true;  // using the same version.
 }