Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tighter UI #371

Merged
merged 4 commits into from
Feb 10, 2021

Conversation

Qblack
Copy link

@Qblack Qblack commented Feb 3, 2021

Hi -
I found this tool and I love it but I plan to use it for something about more microservicesy.
I found it a bit too spacy when I ended up with multiple endpoints worth of apps.
So I made a couple changes which I hope other people will like.
Ignore the blueprint field - I'm assuming that should be another PR.

image

@alexander34ro
Copy link

@mircealungu I checked the changes and they look good. I see no issues in merging this.


@media (min-width: 1500px) {
.container {
max-width: 1600px !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't both these be the same?
or at least the max-width smaller than min-width?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I have no idea. @media (min-width: 1200px){.container{max-width:1140px}} looks like you are right though. I think I understood it backwards.
I changed the min-width to 1644px and it still looks good for me.

@mircealungu
Copy link
Member

Did you make the table rows less tall?
Without a before/after view it's hard for me to imagine the changes :(

@Qblack
Copy link
Author

Qblack commented Feb 10, 2021

Did you make the table rows less tall?
Without a before/after view it's hard for me to imagine the changes :(

More compact yeah - I plan to end up with a lot end points in this. Heres a screen shot from the live demo for a before

image

@mircealungu mircealungu merged commit bea4de5 into flask-dashboard:development Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants