Bugfix: Fixed incorrect dashboard/api usage in reporting.js
#397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API endpoints were still assuming the API is hosted at `/dashboard/*`. This has been fixed.
us88
changed the title
dashboard/api usage in reporting.js
|
@thejager - this looks good to me! what do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The endpoint strings in reporting.js were still assuming that the API is hosted at
/dashboard/.I changed them so that they match the endpoint strings in other files (just
api/*).Changes also applied to the static app.js file. The diff is terrible though... Not sure if I was supposed to do this, I guess it's part of a pipeline you have in place?