Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyproject.toml with flask-wtf>1.1 #34

Merged
merged 1 commit into from
May 4, 2023

Conversation

oegedijk
Copy link
Contributor

@oegedijk oegedijk commented May 2, 2023

Updates the dependency of flask-wtf to deal with issue mentioned in #33

Copy link
Member

@cuducos cuducos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks! I'll try to merge and publish a release today or tomorrow : )

@oegedijk
Copy link
Contributor Author

oegedijk commented May 2, 2023

Also can probably get rid of support for python 3.6 and 3.7. And maybe add 3.9 and 3.10 to the test matrix: https://github.com/flask-extensions/Flask-SimpleLogin/blob/main/.github/workflows/tests.yaml

@cuducos
Copy link
Member

cuducos commented May 2, 2023

BTW don't worry about Python 3.6. It has reached its end-of-life, so no problem to drop support for Python 3.6 moving forward.

@cuducos
Copy link
Member

cuducos commented May 2, 2023

Also can probably get rid of support for python 3.6 and 3.7. And maybe add 3.9 and 3.10 to the test matrix

I'd keep 3.7 (it hasn't reached end-of-life). Beyond that, adding 3.10 is a great contribution!

3.9 is already there ; )

@cuducos
Copy link
Member

cuducos commented May 2, 2023

If you get to change that before I do, we also need to update the supported versions on pyproject.toml:

"Programming Language :: Python :: 3.6",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",

@cuducos cuducos changed the base branch from main to v0.1.2 May 4, 2023 15:03
@cuducos cuducos merged commit 3a0cbf2 into flask-extensions:v0.1.2 May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants