Allow exception propagation when app.propagate_exceptions is set #111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check in
Api.handle_error
that propagates exceptions whenFlask.propagate_exceptions
is set. This honors theapp.testing
setting as established at http://flask.pocoo.org/docs/api/#flask.Flask.test_client that propagates exceptions instead of returning Flask responses. Otherwise behavior is inconsistent with Flask and testing is harder.In general it would be nice to use Flask's error handlers instead of hacking a level above them, this would alleviate having to place another check (propagate_exceptions is already checked in flask). I am not sure if the handlers are
good enough to support wrapping all exceptions into json responses though.