Fix import of private function for flask 2.0.0 #910
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flask commit b146a13f633b0e2e26e3b8383b3db0feb563bc83 moved `def _endpoint_from_view_func` from `src/flask/helpers.py` to `src/flask/scaffold.py` It looks like this will be released with flask 2.0.0
joshfriend
reviewed
Apr 20, 2021
| from flask.helpers import _endpoint_from_view_func | ||
| except: | ||
| # Flask >= 2.0.0 | ||
| from flask.scaffold import _endpoint_from_view_func |
There was a problem hiding this comment.
what if we ditch the private method use and copy its implementation (which is just return view_func.__name__)?
There was a problem hiding this comment.
seems like a better solution than importing a private function :)
|
Why was this issue closed and the PR branch deleted? The patch has not been released. |
|
@rena2damas It has been fixed in PR #915 in a way that does not require importing private flask functions, but it has not been released yet. |
|
@schuderer the merged fix was only added after my comment was made |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flask commit b146a13f633b0e2e26e3b8383b3db0feb563bc83
moved
def _endpoint_from_view_funcfromsrc/flask/helpers.pytosrc/flask/scaffold.pyIt looks like this will be released with flask 2.0.0