Issue661 #662
Closed
Issue661 #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Not sure why GitHub Actions uses 3.1 instead of "3.10". Could you look into that? I guess putting the versions in quotes will fix it. Seems like there is still a error in the tests but I believe that this is a pytest issue which we could fix in a later PR. |
|
It looks like you are correct, the versions should be strings, in the github actions they are using strings, and in hindsight it makes sense that without quotes it interprets 3.10 as being the same as 3.1. Some of the other problems seem to be caused by invalid dates. The tests fail when you feed it a date like |
|
I'll close this pull request as i have an updated one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the python versions from tests to 3.10, 3.11, 3.12