This repository has been archived by the owner on May 30, 2023. It is now read-only.
dev-lang/go: delete go 1.6 #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 4, 2021 16:58
Now that Docker 1.12 is gone, we can delete go 1.6 completely. Note, we do not delete go 1.7, which is still needed by containerd 0.2.6 and docker 17.03.
Now that `dev-lang/go` 1.6 is gone, we need to also delete it from the SDK dependencies list.
dongsupark
changed the title
krnowak
approved these changes
Feb 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Docker 1.12 is gone, we can delete go 1.6 completely.
we need to also delete it from the SDK dependencies list.
Note, we do not delete go 1.7, which is still needed by containerd 0.2.6 and docker 17.03.
This PR should be merged one day after #826 was merged, so nightly builds could not be broken.
Testing done
CI passed: http://localhost:9091/job/os/job/manifest/1960/cldsv/
Note, the CI build was running including the deletion of Docker 1.12, and it worked well.
Though the Go 1.6 part is not included in that Docker PR, because if we delete Go 1.6 at once, the nightly build will be broken.