Skip to content
This repository has been archived by the owner on May 30, 2023. It is now read-only.

changelog: Add placeholder directory to add the changelogs #250

Merged
merged 1 commit into from
Nov 24, 2021
Merged

changelog: Add placeholder directory to add the changelogs #250

merged 1 commit into from
Nov 24, 2021

Conversation

sayanchowdhury
Copy link
Contributor

No description provided.

@sayanchowdhury sayanchowdhury requested a review from a team November 19, 2021 07:54
tormath1
tormath1 reviewed Nov 19, 2021
View reviewed changes
changelog/README.md Outdated Show resolved Hide resolved
changelog/README.md Outdated Show resolved Hide resolved
changelog/README.md Outdated Show resolved Hide resolved
changelog/README.md Outdated Show resolved Hide resolved
changelog/README.md Outdated Show resolved Hide resolved
@tormath1
Copy link
Contributor

It's just general suggestion ⬆️ Glad to have this into the main Flatcar repository :D

@pothos
Copy link
Contributor

pothos commented Nov 19, 2021

Looks good, I think we need the top level CHANGELOG.md file only in the flatcar-scripts repo which will get the other repos as submodules and could be a good place to generate the final file (currently the generator would need to get the path to portage-stable/coreos-overlay). One thing to note is that the final file is different from the website content - it has all changes per release while on the website we list the releases changes per channel with an additional entry about the changes compared to a previous channel releases when a transition happens. We can even discuss to skip generating the final file but I think it has a value to see the changes that happened incrementally up to this release while on the website we can't see this well due to the channel split which forces to switch the tabs.

krnowak
krnowak reviewed Nov 19, 2021
View reviewed changes
changelog/README.md Outdated Show resolved Hide resolved
changelog/README.md Outdated Show resolved Hide resolved
pothos
pothos reviewed Nov 24, 2021
View reviewed changes
changelog/README.md Outdated Show resolved Hide resolved
pothos
pothos approved these changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@pothos pothos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this it good to go and can be changed based on experience from starting to use it :)

@sayanchowdhury @tormath1 @pothos
changelog: Add placeholder directory to add the changelogs
a2cce13 
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
Co-authored-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Co-authored-by: Kai Lüke <pothos@users.noreply.github.com>
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
@sayanchowdhury sayanchowdhury merged commit f53a59b into main Nov 24, 2021
@sayanchowdhury sayanchowdhury deleted the sayan/mandate-changelog-entry branch November 24, 2021 17:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@t-lo t-lo t-lo left review comments

@krnowak krnowak krnowak left review comments

@tormath1 tormath1 tormath1 left review comments

@pothos pothos pothos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sayanchowdhury @tormath1 @pothos @t-lo @krnowak