Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2605.5.0 building kernel modules doesn't work #195

Closed
endzyme opened this issue Sep 23, 2020 · 3 comments
Closed

2605.5.0 building kernel modules doesn't work #195

endzyme opened this issue Sep 23, 2020 · 3 comments
Assignees
Labels
kind/bug Something isn't working kind/upgrade-issue

Comments

@endzyme
Copy link

endzyme commented Sep 23, 2020

Description

Broken makefile in build/ stops the ability to build modules which use --with-linux-obj=/usr/lib64/modules/5.4.66-flatcar/build.

See 2512.5.0 in /usr/lib64/modules/5.4.66-flatcar/build/Makefile vs 2605.5.0:

2512.5.0

# Automatically generated by ../source/scripts/mkmakefile: don't edit

VERSION = 4
PATCHLEVEL = 19

lastword = $(word $(words $(1)),$(1))
makedir := $(dir $(call lastword,$(MAKEFILE_LIST)))

ifeq ("$(origin V)", "command line")
VERBOSE := $(V)
endif
ifneq ($(VERBOSE),1)
Q := @
endif

MAKEARGS := -C ../source
MAKEARGS += O=$(if $(patsubst /%,,$(makedir)),$(CURDIR)/)$(patsubst %/,%,$(makedir))

MAKEFLAGS += --no-print-directory

.PHONY: __sub-make $(MAKECMDGOALS)

__sub-make:
	$(Q)$(MAKE) $(MAKEARGS) $(MAKECMDGOALS)

$(filter-out __sub-make, $(MAKECMDGOALS)): __sub-make
	@:

2605.5.0

# Automatically generated by /build/amd64-usr/var/tmp/portage/sys-kernel/coreos-modules-5.4.66/work/coreos-modules-5.4.66/source/scripts/mkmakefile: don't edit
include /build/amd64-usr/var/tmp/portage/sys-kernel/coreos-modules-5.4.66/work/coreos-modules-5.4.66/source/Makefile

/build/amd64-usr/var/tmp/portage/sys-kernel/coreos-modules-5.4.66/work/coreos-modules-5.4.66/source doesn't exist..

I was able to get builds working by changing the Makefile to use include /usr/lib64/modules/5.4.66-flatcar/source/Makefile

Impact

Can't build kernel modules

Environment and steps to reproduce

  1. Set-up: wget both the 2605.5.0 and the 2512.5.0 developer developer containers, and try to compile a module which uses --with-linux-obj=...

Expected behavior
Worked previously

@t-lo t-lo added kind/bug Something isn't working kind/upgrade-issue labels Sep 24, 2020
@sayanchowdhury sayanchowdhury self-assigned this Sep 24, 2020
@goochjj
Copy link

goochjj commented Sep 24, 2020

This is the solution I'm using

sed -i "s|/build/amd64-usr/var/tmp/portage/sys-kernel/coreos-modules-.*/work/coreos-modules-.*/source|/lib/modules/${KV}/source|g" /lib/modules/${KV}/build/Makefile

Where KV is the kernel version

@margamanterola
Copy link
Contributor

This has been fixed with flatcar-archive/coreos-overlay#614, which will be included in the upcoming releases.

@endzyme
Copy link
Author

endzyme commented Oct 1, 2020

Looks like it was released on https://www.flatcar-linux.org/releases/#release-2605.6.0

@endzyme endzyme closed this as completed Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working kind/upgrade-issue
Projects
None yet
Development

No branches or pull requests

5 participants