Split the network unit logic from Apply() #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change moves some code in the main function to fetch the metadata and create the env a bit earlier. It also splits the network unit creation from the initialize.Apply() function. This also fixes a bug where systemd-networkd was restarted before the units were actually processed. Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
|
Closing in favor of #21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split network config from initialize.Apply()
This change moves some code in the main function to fetch the metadata and create the env a bit earlier. It also splits the network unit creation from the initialize.Apply() function.
This also fixes a bug where systemd-networkd was restarted before the units were actually processed.
How to use
This change does not change the behavior of
coreos-cloudinit, except for some logging messages.Testing done
None yet. This change is part of a larger effort, but is useful on it's own. Will update the PR once testing has been done.
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.