tools, docs: Parse version.txt using shlex and bash #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://lemon-wave-085522403-279.westeurope.1.azurestaticapps.net |
This is to guard against quoted values.
This guards against possible quotes.
krnowak
force-pushed
the
krnowak/shlex-version-txt
branch
from
156bcb0
to
f2dab49
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://lemon-wave-085522403-279.westeurope.1.azurestaticapps.net |
krnowak
changed the title
pothos
reviewed
Oct 30, 2023
| @@ -127,7 +127,7 @@ read SSH_KEY_ID | |||
| If not done yet, [create a custom image](https://developers.digitalocean.com/documentation/v2/#create-a-custom-image) from the current Flatcar Container Linux Stable version: | |||
|
|
|||
| ```shell | |||
| VER=$(curl https://stable.release.flatcar-linux.net/amd64-usr/current/version.txt | grep -m 1 FLATCAR_VERSION_ID= | cut -d = -f 2) | |||
| VER=$(source <(curl https://stable.release.flatcar-linux.net/amd64-usr/current/version.txt); echo "${FLATCAR_VERSION_ID}") | |||
There was a problem hiding this comment.
If this should serve as reference for copy paste it would be good to have error reporting with set -euo pipefail still work. The <(CMD) usage swallows the error - maybe an explicit check for a non-empty string could be added before the echo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to guard against quoted values.