internal/exec: fix package name to fetch #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongsupark
approved these changes
Jul 8, 2020
There was a problem hiding this comment.
Good catch.
A background story about it:
Upstream coreos/ignition already fixed the package name via coreos/ignition@c169ad9 .
The commit however consists of 3 different package name fixes. One of the fixes is exactly the same as this PR. The other 2 fixes are unfortunately not valid in flatcar-linux/ignition, which has neither internal/exec/stages/mount nor internal/exec/stages/umount. That's why it is not possible to simply cherry-pick the upstream commit into Flatcar.
So I think this PR makes sense.
dongsupark
pushed a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Jul 8, 2020
Update ignition to fix an internal package name to fetch. Pulls in flatcar/ignition#14
dongsupark
pushed a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Jul 8, 2020
Update ignition to fix an internal package name to fetch. Pulls in flatcar/ignition#14
dongsupark
pushed a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Jul 8, 2020
Update ignition to fix an internal package name to fetch. Pulls in flatcar/ignition#14
dongsupark
pushed a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Jul 8, 2020
Update ignition to fix an internal package name to fetch. Pulls in flatcar/ignition#14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Title: describe the change in one sentence]
fixes an incorrect package name
How to use
run existing unit/integration tests
Testing done
none