Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dataurl module to v1.0.0 #29

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

johananl
Copy link
Collaborator

@johananl johananl commented Nov 9, 2021

Update dataurl module to v1.0.0

Upstream has created a tag to improve stability so we should use it.

How to use

Run make and ensure the binary is built.

Testing done

Couldn't really test this since go test -v ./... fails even before this change.

Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com>
@invidian
Copy link
Member

invidian commented Nov 9, 2021

See also b1c07d3.

Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When blackbox tests are skipped, everything passes, so I assume things work.

Perhaps blackbox tests should be hidden behind a build tag, so they don't fail out of the box.

Copy link
Member

@jepio jepio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this, my PR can wait.

@invidian invidian merged commit eda58aa into flatcar:flatcar-master Nov 10, 2021
@johananl johananl deleted the johananl/dataurl-v1 branch November 10, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants