Skip to content

Commit

Permalink
kola/ torcx removal: address feedback from PR review
Browse files Browse the repository at this point in the history
Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
  • Loading branch information
t-lo committed Oct 16, 2023
1 parent 16b5ee1 commit ac393eb
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 3 additions & 1 deletion kola/tests/sysext/disable_containerd.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
// Copyright 2023 The Flatcar Maintainers.
//
// SPDX-License-Identifier: Apache-2.0
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
Expand Down Expand Up @@ -51,7 +53,7 @@ storage:
func containerdDisable(c cluster.TestCluster) {
m := c.Machines()[0]
output := c.MustSSH(m,
`test ! -f /usr/bin/containerd || echo "ERROR"`)
`test -f /usr/bin/containerd && echo "ERROR" || true`)
if string(output) == "ERROR" {
c.Errorf("/usr/bin/containerd exists even when sysext is disabled!")
}
Expand Down
4 changes: 3 additions & 1 deletion kola/tests/sysext/disable_docker.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
// Copyright 2023 The Flatcar Maintainers.
//
// SPDX-License-Identifier: Apache-2.0
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
Expand Down Expand Up @@ -46,7 +48,7 @@ storage:
func dockerDisable(c cluster.TestCluster) {
m := c.Machines()[0]
output := c.MustSSH(m,
`test ! -f /usr/bin/docker || echo "ERROR"`)
`test -f /usr/bin/docker && echo "ERROR" || true`)
if string(output) == "ERROR" {
c.Errorf("/usr/bin/docker exists even when sysext is disabled!")
}
Expand Down

0 comments on commit ac393eb

Please sign in to comment.