Skip to content

Commit

Permalink
kola/test: disable tests that won't work with docker 20.10
Browse files Browse the repository at this point in the history
These tests are 'docker.oldclient' and 'google.kubernetes.basic.docker.*'.

'docker.oldclient' tries to run docker cli 1.9 against daemon in the
image, and fails with:

  --- FAIL: docker.oldclient (29.22s)
          cluster.go:117: Error response from daemon: 400 Bad Request: malformed Host header
          cluster.go:130: "/home/core/docker-1.9.1 run echo echo 'IT WORKED'" failed: output , status Process exited with status 1

This is related to moby/moby#39076, merged into
20.10 which removed some backwards compatibility.

The 'google.kubernetes.basic.docker.*' tests fails with the following
message in journal:

  Jul 15 14:17:42.446942 kubelet[4663]: F0715 14:17:42.446505    4663 server.go:274] failed to run Kubelet: misconfiguration: kubelet cgroup driver: "cgroupfs" is different from docker cgroup driver: "systemd"

Kubernetes release 1.19 is the first one that properly supports the unified cgroup hierarchy.
We also have other tests that test that kubernetes works (kubeadm) so we
can disable the legacy ones.

The old tests should be removed once the docker 20.10 upgrade has
propagated to all channels.

See also flatcar-archive/coreos-overlay#931

Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
  • Loading branch information
jepio committed Aug 9, 2021
1 parent d33d88e commit aff2741
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
3 changes: 3 additions & 0 deletions kola/tests/docker/docker.go
Expand Up @@ -26,6 +26,7 @@ import (
"golang.org/x/crypto/ssh"
"golang.org/x/net/context"

"github.com/coreos/go-semver/semver"
"github.com/coreos/mantle/kola/cluster"
"github.com/coreos/mantle/kola/register"
"github.com/coreos/mantle/lang/worker"
Expand Down Expand Up @@ -76,6 +77,8 @@ func init() {
Name: "docker.oldclient",
Architectures: []string{"amd64"},
Distros: []string{"cl"},
// incompatible with docker >=20.10
EndVersion: semver.Version{Major: 2955},
})
register.Register(&register.Test{
Run: dockerUserns,
Expand Down
3 changes: 3 additions & 0 deletions kola/tests/kubernetes/basic.go
Expand Up @@ -21,6 +21,7 @@ import (
"strings"
"time"

"github.com/coreos/go-semver/semver"
"github.com/coreos/mantle/kola/cluster"
"github.com/coreos/mantle/kola/register"
"github.com/coreos/mantle/platform"
Expand Down Expand Up @@ -54,6 +55,8 @@ func init() {
ClusterSize: 0,
Platforms: []string{"gce", "do", "aws", "qemu", "azure"}, // TODO: fix packet, esx
Distros: []string{"cl"},
// incompatible with docker >=20.10
EndVersion: semver.Version{Major: 2955},
})
}
}
Expand Down

0 comments on commit aff2741

Please sign in to comment.