Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for multipart mime in coreos-cloudinit #437

Merged

Conversation

gabriel-samfira
Copy link
Member

Add tests for the multipart mime support in coreos-cloudinit

The new multipart mime support that is currently being proposed against coreos-cloudinit needs to be tested. This PR adds the needed tests.

These tests will validate that we properly parse the multipart mime user-data and all parts are run correctly.

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

@gabriel-samfira
Copy link
Member Author

It seems I don't have access to push to ghcr.io/flatcar/mantle. I'll try and push to my own fork.

@pothos
Copy link
Member

pothos commented May 23, 2023

It seems I don't have access to push to ghcr.io/flatcar/mantle. I'll try and push to my own fork.

Strange, I thought that would work for all PRs…

@gabriel-samfira
Copy link
Member Author

It seems I don't have access to push to ghcr.io/flatcar/mantle. I'll try and push to my own fork.

Strange, I thought that would work for all PRs…

Nope. This section:

- name: Login to registry
uses: docker/login-action@v2
with:
registry: ${{ env.REGISTRY }}
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

Defines the login credentials. The actor in this case is the PR author and I do not have write access to the mantle packages.

@pothos
Copy link
Member

pothos commented May 23, 2023

Is the token the same or also bound to the author?

@gabriel-samfira
Copy link
Member Author

Yup. The actor and the token belong to the person triggering the workflow. If triggered via PR, they belong to the author. If triggered via workflow_dispatch they belong to the person running the action.

@gabriel-samfira gabriel-samfira force-pushed the add-multi-mime-tests branch 2 times, most recently from 070bbb6 to 7a19a2b Compare May 23, 2023 11:43
@gabriel-samfira gabriel-samfira marked this pull request as draft June 3, 2023 07:56
@gabriel-samfira
Copy link
Member Author

Converted to draft for now. This opened a can of worms. Apparently I need to parse the userdata here as well to determine its type and add the testing ssh keys to it so kola can access the vms. Will update it next week.

@gabriel-samfira gabriel-samfira force-pushed the add-multi-mime-tests branch 2 times, most recently from f3f2adf to 414c452 Compare June 7, 2023 19:33
Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
@gabriel-samfira gabriel-samfira marked this pull request as ready for review June 7, 2023 20:19
Co-authored-by: Kai Lüke <pothos@users.noreply.github.com>
kola/tests/misc/cloudinit.go Outdated Show resolved Hide resolved
Copy link
Member

@pothos pothos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks a lot! I added a few comments.

gabriel-samfira and others added 2 commits June 8, 2023 16:24
Co-authored-by: Kai Lüke <pothos@users.noreply.github.com>
Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
@gabriel-samfira gabriel-samfira merged commit ede426f into flatcar:flatcar-master Jun 8, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants