kola: Disable the public update server by default #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tormath1
reviewed
Oct 6, 2023
pothos
force-pushed
the
kai/disable-updates
branch
3 times, most recently
from
fe6b24c
to
ae3b501
Compare
This might have been an oversight: for release tests we used the public Nebraska server. This was already disabled for FCOS but not for the original CoreOS/Flatcar CL. Disable the public update server by default. The update tests overwrite it with their specific setting. In case a future test needs the default the usual test flag escape hatch in the form of NoDisableUpdates is added.
pothos
force-pushed
the
kai/disable-updates
branch
from
ae3b501
to
65ea860
Compare
|
Some unrelated kubeadm tests failed, rest looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might have been an oversight: for release tests we used the public Nebraska server. This was already disabled for FCOS but not for the original CoreOS/Flatcar CL.
Disable the public update server by default. The update tests overwrite it with their specific setting. In case a future test needs the default the usual test flag escape hatch in the form of NoDisableUpdates is added.
How to use
Testing done
here