.github/workflow: removing trailing spaces in calico manifest #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it happens that manifest have trailing space at the end of the key/value. The diff wants to remove the trailing space so it fails when applying the generated patch. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
|
I think that the issue was that the original calico manifest had the trailing spaces and they removed them. Our modified copy didn't have them, so then our action failed when it tried to apply a patch that drops the trailing spaces from lines that didn't have those anyway. |
|
Yeah, the issue was transient. We can revisit this PR if this trailing whitespace becomes an issue again. So for now I'd merge my PR and close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it happens that manifest have trailing space at the end of the key/value. The diff wants to remove the trailing space so it fails when applying the generated patch.
Noticed the issue here: #467
The github action is failing since a while (see: https://github.com/flatcar/mantle/actions/workflows/sync-calico-version.yml) because of this -> the images are not mirrored. Tested with https://github.com/flatcar/mantle/actions/runs/6560916156/job/17819529865