Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull in flatcar/init and bootengine changes to ignore mana VF in networkd #1131

Merged
merged 3 commits into from Sep 15, 2023

Conversation

jepio
Copy link
Member

@jepio jepio commented Sep 12, 2023

Pull in flatcar/init change to ignore mana VF in networkd

Add mana driver to the list of drivers ignored by networkd on Azure. Pulls in:

How to use

[ describe what reviewers need to do in order to validate this PR ]

Testing done

Will test in jenkins to see that it doesn't break anything in existing instances on azure, but otherwise we don't have access to mana instances yet.

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

@dongsupark
Copy link
Member

dongsupark commented Sep 12, 2023

It needs a rebase.

EDIT: changelog is already there.

@github-actions
Copy link

github-actions bot commented Sep 12, 2023

Build action triggered: https://github.com/flatcar/scripts/actions/runs/6196727380

@jepio jepio changed the title Pull in flatcar/init change to ignore mana VF in networkd Pull in flatcar/init and bootengine changes to ignore mana VF in networkd Sep 15, 2023
The flatcar/init commits includes a change to the azure sriov config file that
excludes devices managed by the mana driver from networkd management, just like
mlx4 and mlx5 devices.

Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
The flatcar/bootengine commit includes a change to the azure sriov config file that
excludes devices managed by the mana driver from networkd management, just like
mlx4 and mlx5 devices.

Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
@jepio
Copy link
Member Author

jepio commented Sep 15, 2023

Running testing on Azure to ensure no regressions:
http://192.168.42.7:8080/job/container/job/packages_all_arches/2519/cldsv/

@jepio jepio merged commit bf21753 into main Sep 15, 2023
1 check failed
jepio added a commit that referenced this pull request Sep 18, 2023
Pull in flatcar/init and bootengine changes  to ignore mana VF in networkd
jepio added a commit that referenced this pull request Sep 18, 2023
Pull in flatcar/init and bootengine changes  to ignore mana VF in networkd
jepio added a commit that referenced this pull request Sep 18, 2023
Pull in flatcar/init and bootengine changes  to ignore mana VF in networkd
@jepio jepio deleted the azure-mana-vf branch September 18, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants