Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use qcow2 inline compression #1132

Merged
merged 1 commit into from Sep 25, 2023

Conversation

krishjainx
Copy link
Contributor

Provide the .img qcow2 without wrapped compression by enabling the inline compression

#1135 by @tuxtof

Spoke with @pothos

@krishjainx krishjainx temporarily deployed to development September 12, 2023 21:48 — with GitHub Actions Inactive
@pothos
Copy link
Member

pothos commented Sep 12, 2023

Started a github PR build, we should also test on Jenkins (I can do this later but if someone does it before me, also good)

@github-actions
Copy link

github-actions bot commented Sep 12, 2023

Build action triggered: https://github.com/flatcar/scripts/actions/runs/6312120421

@sayanchowdhury
Copy link
Member

@sayanchowdhury
Copy link
Member

There is one failure:

 --- FAIL: systemd.journal.user (16.95s)
         cluster.go:130: "journalctl --user --unit hello.service | grep Foo" failed: output , status Process exited with status 1

@pothos
Copy link
Member

pothos commented Sep 25, 2023

There is one failure:

 --- FAIL: systemd.journal.user (16.95s)
         cluster.go:130: "journalctl --user --unit hello.service | grep Foo" failed: output , status Process exited with status 1

That looks unrelated

@pothos
Copy link
Member

pothos commented Sep 25, 2023

The jenkins build got cleaned up, can't see the results but I think it's ok to merge if the reported failure was only about an unrelated kola test.
Should we backport this to all channels?

@dongsupark dongsupark added main and removed on-hold labels Sep 25, 2023
@dongsupark
Copy link
Member

Let's merge.
I am fine with backports.

@pothos pothos merged commit 9ffceaf into flatcar:main Sep 25, 2023
4 of 7 checks passed
@pothos
Copy link
Member

pothos commented Sep 25, 2023

Let's see how the nightly build turns out before backporting.

dongsupark added a commit that referenced this pull request Sep 26, 2023
pothos added a commit that referenced this pull request Sep 26, 2023
Allow use qcow2 inline compression
pothos added a commit that referenced this pull request Sep 26, 2023
Allow use qcow2 inline compression
pothos added a commit that referenced this pull request Sep 26, 2023
Allow use qcow2 inline compression
pothos added a commit that referenced this pull request Sep 26, 2023
Allow use qcow2 inline compression
@pothos
Copy link
Member

pothos commented Sep 26, 2023

Backported

dongsupark added a commit that referenced this pull request Sep 27, 2023
dongsupark added a commit that referenced this pull request Sep 27, 2023
dongsupark added a commit that referenced this pull request Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants