switch default torcx build to docker-20 #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
7 tasks
We are enabling CgroupV2 support globally, which requires Docker 20.10. It is possible to return to CgroupV1 locally via kernel commandline, but that will still work with Docker 20. If someone really needs older Docker versions we will recommend to also fetch torcx packages from older releases or rely on upstream binaries.
pothos
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
switch default torcx build to docker-20
This switches the default torcx build to docker-20 and removes older torcx packages. Older docker versions don't support cgroupv2 which is also enabled at the same time.
How to use
Pull this and flatcar-archive/coreos-overlay#931.
./build_imageTesting done
Builds successfully. Still need to run the change through jenkins.