sys-fs/multipath-tools: Disable realtime scheduling for multipathd #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a dropin that prevents the service from controlling its own scheduling. On newer Flatcar releases, service ordering seems to have changed and multipathd is able to configure realtime scheduling before systemd tries (and fails) to enable the cpu controller. The dropin is meant to enforce sane behavior, and matches older Flatcar releases where cpu controller was enabled before multipathd tries (and fails) to configure realtime scheduling. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
ader1990
reviewed
Mar 18, 2024
| # if any such process exists then cpu controller can't be enabled. | ||
| # This poses a bit of a dilemma. | ||
| # Block realtime control for the process, but give it highest non-rt priority. | ||
| RestrictRealtime=yes |
There was a problem hiding this comment.
LGTM, worked on my local setup as well.
|
Build action triggered: https://github.com/flatcar/scripts/actions/runs/8346002605 |
Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
|
Added a changelog. |
|
Not doing a mantle test case for now as this is unlikely to regress. |
jepio
added a commit
that referenced
this pull request
Mar 19, 2024
sys-fs/multipath-tools: Disable realtime scheduling for multipathd Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
jepio
added a commit
that referenced
this pull request
Mar 19, 2024
sys-fs/multipath-tools: Disable realtime scheduling for multipathd Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
jepio
added a commit
that referenced
this pull request
Mar 19, 2024
sys-fs/multipath-tools: Disable realtime scheduling for multipathd Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sys-fs/multipath-tools: Disable realtime scheduling for multipathd
Add a dropin that prevents the service from controlling its own scheduling. On newer Flatcar releases, service ordering seems to have changed and multipathd is able to configure realtime scheduling before systemd tries (and fails) to enable the cpu controller. The dropin is meant to enforce sane behavior, and matches older Flatcar releases where cpu controller was enabled before multipathd tries (and fails) to configure realtime scheduling.
How to use
[ describe what reviewers need to do in order to validate this PR ]
TODO: mantle test case
TODO: changelog
Testing done
[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.