Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm64: fix vnc console on qemu-kvm arm64 #830

Merged
merged 1 commit into from May 30, 2023

Conversation

ader1990
Copy link
Contributor

Fixes-Bug: flatcar/Flatcar#1030

testing in progress, PR was made to be able to have a built image.

@ader1990
Copy link
Contributor Author

@pothos the change seems to work as expected, tested with the github artifacts produced by the github action.

BEFORE
Screenshot 2023-05-22 at 10 59 04

AFTER:

Screenshot 2023-05-22 at 11 01 53

@pothos
Copy link
Member

pothos commented May 22, 2023

Thanks for testing! Please move the change to the commonconfig file to also have it in amd64. We also need a changelog entry like - Enabled the virtio GPU driver ([scripts#830](https://github.com/flatcar/scripts/pull/830)) in a new file changelog/changes/2023-05-22-virtio-gpu.md

@ader1990
Copy link
Contributor Author

Thanks for testing! Please move the change to the commonconfig file to also have it in amd64. We also need a changelog entry like - Enabled the virtio GPU driver ([scripts#830](https://github.com/flatcar/scripts/pull/830)) in a new file changelog/changes/2023-05-22-virtio-gpu.md

Sure, need to verify first if the issue is actually present on the amd64 image.

@ader1990
Copy link
Contributor Author

Thanks for testing! Please move the change to the commonconfig file to also have it in amd64. We also need a changelog entry like - Enabled the virtio GPU driver ([scripts#830](https://github.com/flatcar/scripts/pull/830)) in a new file changelog/changes/2023-05-22-virtio-gpu.md

Hello, I have tested on amd64, and the issue is not reproducing wihout this fix. should I leave the amd64 config unchanged in this case?

@pothos
Copy link
Member

pothos commented May 26, 2023

I think it's a good idea to still have it on amd64 even if by default another driver is used.

@ader1990 ader1990 force-pushed the arm64_qemu_enable_vnc_display branch from 23aab8b to a1651b7 Compare May 26, 2023 12:32
@ader1990 ader1990 changed the title arm64: possible fix for vnc console arm64: fix vnc console on qemu-kvm arm64 May 26, 2023
@ader1990
Copy link
Contributor Author

I think it's a good idea to still have it on amd64 even if by default another driver is used.

Hello @pothos, I have updated the PR with the changes requested.

Thank you.

@ader1990 ader1990 force-pushed the arm64_qemu_enable_vnc_display branch from a1651b7 to a1be2ae Compare May 26, 2023 12:41
Without DRM configured in the Linux kernel, the VNC console will show a
screen with the message: "Display output is not active".

Although the on QEMU-KVM AMD64 the issue is not presented, I have
enabled the same flags for consistency.

Fixes: flatcar/Flatcar#1030
@ader1990 ader1990 force-pushed the arm64_qemu_enable_vnc_display branch from a1be2ae to c76e969 Compare May 26, 2023 12:55
@pothos
Copy link
Member

pothos commented May 26, 2023

Thank, looks good - I'll start a test job now.

@gabriel-samfira
Copy link
Member

/build-image

@ader1990
Copy link
Contributor Author

Hello @pothos, I have updated the PR and @gabriel-samfira triggered a PR test suite run here https://github.com/flatcar/scripts/actions/runs/5111437226, which partially passed (kolla still broken).

Anything else required for the PR to be merged?

Thank you.

@ader1990
Copy link
Contributor Author

Thank, looks good - I'll start a test job now.

The test job you triggered seems to have been cancelled by another higher priority run: https://github.com/flatcar/scripts/actions/runs/5090846591 -> Canceling since a higher priority waiting request for 'PR command build dispatcher-pr-command-main' exists.

@pothos pothos merged commit 84166fc into flatcar:main May 30, 2023
@pothos
Copy link
Member

pothos commented May 30, 2023

All good, there are some kernel config changes compared to 5.15 and I don't know if this change or the 6.1 kernel update caused them. Anyway something for a new PR.

@ader1990
Copy link
Contributor Author

thank you, @pothos. Because CONFIG_DRM is now set, the make old|defconfig should add some more diffs in the resulted config. Possibly this is the difference you are seeing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants